================
@@ -9687,6 +9687,7 @@ def err_deleted_inherited_ctor_use : Error<
 
 def note_called_by : Note<"called by %0">;
 def note_which_is_called_by : Note<"which is called by %0">;
+def note_in_hd_promoted_function : Note<"in HD-promoted function %0">;
----------------
tahonermann wrote:

I'm a little concerned that users won't know what an "HD-promoted" function is. 
The documentation you added in https://github.com/llvm/llvm-project/pull/185926 
is good and helpful, but I suspect few users will see it.

The amount of churn could be reduced by issuing this note only for functions 
that are implicitly `__host__ __device__` functions. In that case, the note 
could be more targeted as in the suggestion below. We would then want to 
customize the note for SYCL, but that is ok and I could do that in a separate 
PR.

```suggestion
def note_in_hd_promoted_function : Note<"in implicit __host__ __device__ 
function %0">;
```

https://github.com/llvm/llvm-project/pull/187153
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to