naveen-seth wrote: > This makes `diagtool` depend on llvm/lib/IR. That seems a bit surprising, is > that really what we want?
I believe this can be resolved by removing `diagtool`’s dependency on `Driver` entirely and instead using [`createDiagOptions` from DependencyScannerImpl/h](https://github.com/llvm/llvm-project/blob/366da1252b2c9d6943fee9886391b27b755e9322/clang/include/clang/DependencyScanning/DependencyScannerImpl.h#L58-L71), rather than creating a compiler invocation as done here: https://github.com/llvm/llvm-project/blob/366da1252b2c9d6943fee9886391b27b755e9322/clang/tools/diagtool/ShowEnabledWarnings.cpp#L70-L80 I've tested this and it passes all unit and regression tests, but I'll only be able to make a proper PR tomorrow. I'd probably move `createDiagOptions` into the `Options` library then. If this is causing issues right now, I don't mind this being reverted. https://github.com/llvm/llvm-project/pull/152770 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
