================ @@ -15,15 +15,30 @@ #include "clang/Driver/ModulesDriver.h" #include "clang/Basic/Diagnostic.h" #include "clang/Basic/LLVM.h" +#include "clang/DependencyScanning/DependencyScanningUtils.h" ---------------- naveen-seth wrote:
`DependencyScanning` doesn’t depend on `Driver`, but the include is not needed and should be removed. I’ve opened a PR to fix it (#187599). Thanks for catching that! Since this isn’t a layering violation, the PR shouldn’t introduce a cyclic dependency, so I haven’t reverted it. https://github.com/llvm/llvm-project/pull/152770 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
