https://github.com/jhuber6 commented:
This seems like we're *really* stretching the new interface to match the old one. The goal is to support users manually modifying `.S` files and then passing it back into the compiler? I can see how that would be more difficult with the new interface. I'm not a huge fan of this, the expected behavior was that you get a `.S` that behaves like a valid host object. I would greatly prefer a new, common interface that gave people the same flexibility rather than bolting more HIP specific handling onto this. But for the sake of expedience I could be talked into this. Theoretically you could make it embed textual assembly in the section, but you'd need to put that in the filename when you send it back to `clang` through the linker wrapper. It would also look weird having a bunch of textual assembly in a global string in an assembly file. https://github.com/llvm/llvm-project/pull/188262 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
