yxsamliu wrote:

> Are we sure we shouldn’t instead update 
> Unit_hipExtModuleLaunchKernel_CheckCodeObjAtt to match the behavior of the 
> new driver, instead of updating this to match the behavior of the old driver?
> 
> Are there other cases besides the failing hip-test that need this?

Some user asked me about how to manually modify assembly code then compile to 
executables and I told them about this approach. We do not know whether there 
are existing HIP apps depending on this feature. However, I do think it is a 
convenient feature for users to quickly get assembly code and tweak them.

https://github.com/llvm/llvm-project/pull/188262
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to