github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,c --
clang/test/Sema/warn-cstring-null-terminator.c
clang/lib/Sema/AnalysisBasedWarnings.cpp clang/lib/Sema/SemaChecking.cpp
--diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang/lib/Sema/AnalysisBasedWarnings.cpp
b/clang/lib/Sema/AnalysisBasedWarnings.cpp
index c6f16cc32..6ec2ee115 100644
--- a/clang/lib/Sema/AnalysisBasedWarnings.cpp
+++ b/clang/lib/Sema/AnalysisBasedWarnings.cpp
@@ -59,8 +59,8 @@
#include "llvm/ADT/StringExtras.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/Support/Debug.h"
-#include "llvm/Support/raw_ostream.h"
#include "llvm/Support/TimeProfiler.h"
+#include "llvm/Support/raw_ostream.h"
#include <algorithm>
#include <deque>
#include <iterator>
@@ -2919,7 +2919,8 @@ static bool areSameSimpleDeclRef(const Expr *E1, const
Expr *E2) {
return D1 && D2 && D1->getDecl() == D2->getDecl();
}
-static std::string getExprAsString(const Expr *E, const PrintingPolicy
&Policy) {
+static std::string getExprAsString(const Expr *E,
+ const PrintingPolicy &Policy) {
SmallString<64> Text;
llvm::raw_svector_ostream OS(Text);
E->printPretty(OS, nullptr, Policy);
@@ -2966,10 +2967,12 @@ class CStringAllocationVisitor : public
StmtVisitor<CStringAllocationVisitor> {
return;
TrackedCStringAllocation &Info = It->second;
- std::string SizeText = getExprAsString(Info.SizeExpr,
S.getPrintingPolicy());
+ std::string SizeText =
+ getExprAsString(Info.SizeExpr, S.getPrintingPolicy());
S.Diag(Info.AllocCall->getBeginLoc(),
- Info.IsRealloc ? diag::warn_fortify_realloc_maybe_removes_null_space
- :
diag::warn_fortify_allocation_maybe_small_for_cstring)
+ Info.IsRealloc
+ ? diag::warn_fortify_realloc_maybe_removes_null_space
+ : diag::warn_fortify_allocation_maybe_small_for_cstring)
<< SizeText << getPlusOneFixIt(Info.SizeExpr, S.getPrintingPolicy());
Info.Warned = true;
}
@@ -3049,7 +3052,8 @@ public:
StringRef Name = getSimpleLibraryFunctionName(CE->getDirectCallee());
if (Name == "strlen" && CE->getNumArgs() == 1) {
MarkAsStringBuffer(CE->getArg(0));
- } else if ((Name == "strcpy" || Name == "strcat") && CE->getNumArgs() ==
2) {
+ } else if ((Name == "strcpy" || Name == "strcat") &&
+ CE->getNumArgs() == 2) {
MarkAsStringBuffer(CE->getArg(0));
} else if (Name == "memcpy" && CE->getNumArgs() == 3) {
if (const Expr *StrlenArg =
diff --git a/clang/lib/Sema/SemaChecking.cpp b/clang/lib/Sema/SemaChecking.cpp
index 69e139600..777a09159 100644
--- a/clang/lib/Sema/SemaChecking.cpp
+++ b/clang/lib/Sema/SemaChecking.cpp
@@ -1169,7 +1169,8 @@ static bool areSameSimpleDeclRef(const Expr *E1, const
Expr *E2) {
return D1 && D2 && D1->getDecl() == D2->getDecl();
}
-static std::string getExprAsString(const Expr *E, const PrintingPolicy
&Policy) {
+static std::string getExprAsString(const Expr *E,
+ const PrintingPolicy &Policy) {
SmallString<64> Text;
llvm::raw_svector_ostream OS(Text);
E->printPretty(OS, nullptr, Policy);
``````````
</details>
https://github.com/llvm/llvm-project/pull/190411
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
