evelez7 wrote:

I don't think this is the best way to do this. In `JSONGenerator` we already 
have a function called `extractTextComments` which is *supposed* to handle the 
referenced issue but it didn't account for nested `TextComment` arrays. I think 
it would be much simpler to handle it there rather than this approach. Could be 
made more robust by passing the `CommentInfo` along with it to check if it is a 
return, etc instead of a bool.

https://github.com/llvm/llvm-project/pull/188739
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to