https://github.com/ilovepi requested changes to this pull request.
I'm pretty luke warm on this design. the bool parameter can be fuctional, but generally this gets messy. perhaps we want a different API? I think you may also need some tests for the other generators, even if they just confrim the existing behavior since the templates aren't updated. I'd suggest adding those for all the mustache based output at least with some kind of fixme/todo detailing what needs to happen to have the new behavior show up. https://github.com/llvm/llvm-project/pull/188739 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
