steakhal wrote: Thank you for submitting a patch. While I agree with the rational that not crashing is objectively better than anything else. However, I think we should take the time and reflect if we could do something better, because from what I can see in this patch that assume would `assume` is simply ignore LCVs - while the caller will have the assumption (pun intended) that the call will bring in the condition to the State.
Have you explored the root cause of why we have an LCV here? Should we have an LCV here at all? From the test code, I suspect the bitcasts have something to do with this crash, thus with these LCVs. But do the non-standard c++ zero sized arrays play a part here, or they just an artifact of the reduction steps? https://github.com/llvm/llvm-project/pull/190815 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
