to268 wrote: > > You should not format code (manually or automatically) outside of your > > changes. It makes it harder to review your PR. > > Can you elaborate what you mean by this? I attached the clang formatter to my > VSCode settings file now so that when I saw it automatically formats, is that > not something I should be doing?
What I was saying was you should not format the entire file you are editing, only the parts of the code you have changed. In this case it is better to disable auto formatting in your settings. You can either manually format each part you have changed or format what ends up in the diff using one of the appropriate script in the [clang-format](https://github.com/llvm/llvm-project/tree/main/clang/tools/clang-format) tools directory. The format job checks only the formatting of what you have changed anyways, not the entire file you have modified. https://github.com/llvm/llvm-project/pull/190840 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
