================
@@ -59,6 +59,8 @@ class RValue {
     return value;
   }
 
+  mlir::Value getAnyValue() const { return value; }
----------------
andykaylor wrote:

Classic codegen has `getScalarVal`, and it would make sense to align with that. 
Right now, it should be a simple matter to replace all uses of `getValue` with 
`getScalarVal`. I have concerns about `getAnyVal` though. I think the assert in 
`getScalarValue` in classic codegen is necessary because aggregate and complex 
r-values don't have a single value to be returned. It looks to me like maybe we 
have that same issue in CIR with aggregate r-values.

https://github.com/llvm/llvm-project/pull/194027
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to