TPPPP72 wrote: > I don't think `setInvalidDecl` is needed in this case. The attribute is > rejected before it is added to the declaration and the declaration itself > remains valid.
I don't think also. > I think we should remove `setInvalidDecl` to maintain consistency here. > > https://github.com/llvm/llvm-project/blob/8b9cfeac98b99c3edfe0b5f71c8a11044750e50b/clang/lib/Sema/SemaObjC.cpp#L1701-L1705 > > https://github.com/llvm/llvm-project/blob/8b9cfeac98b99c3edfe0b5f71c8a11044750e50b/clang/lib/Sema/SemaObjC.cpp#L1709-L1712 But @AaronBallman previously pointed out that it needed to be added :0 https://github.com/llvm/llvm-project/pull/194856 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
