TPPPP72 wrote:

> > I don't think `setInvalidDecl` is needed in this case. The attribute is 
> > rejected before it is added to the declaration and the declaration itself 
> > remains valid.
> 
> Oh, I see the logic you're using -- even though the declaration was invalid 
> enough to be diagnosed, we didn't add the attribute to the AST node and so 
> the declaration is sufficiently valid again. That's subtle but reasonable IMO.

Well, so I removed `setInvallidDecl` and I have no commit access currently, 
could you please merge it?

https://github.com/llvm/llvm-project/pull/194856
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to