tigbr wrote:
I replaced `LocationContext` incrementally and made sure that every commit compiles and passes the `check-clang-analysis` tests. The order in which I have performed the renaming was decided on how many changes would be needed to fix compilation errors. I was trying to make sure that if I break something I find out about it immediately and not just at the end when there are 2k modified lines. Additionaly, I was hoping that it would allow you guys to perform the review incrementally. I intended to replace the variable and method names as well. In the first four commits, however, I was not really sure whether to do variable, method renaming in separate commits or together with replacing `LocationContext`. Afterwards, I have settled on doing these at the same time. So, I think I have just forgot to go back and rename those variables whose type I have replaced in the first few commits. In short, there should not be any outdated names. In case you do find any it was just accidentally missed, which I will fix. By default, I used the name `SF` for `StackFrame` variables, except for some special cases such as `CallerSF`, `CalleeSF`, `LeakFrame` (for `LeakContext`) etc. In general, this was my methodology. If you would like to know anything more specific I will try to answer as best as I can. https://github.com/llvm/llvm-project/pull/198211 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
