steakhal wrote: > So I'd propose an interactive rebase and squash these 39 commits into a > single commit with an updated commit message - or you could just keep the > squash messages - that might be even better for history. Where would you want to put that squashed commit? Into a new PR (abandoning this)? Into this PR with a force push (potentially messing up the inline review comments)?
I wanted to keep the discussion open for additional changes because you foreshadowed more commits that you could see part of this PR. I didn't want to immediately push back and reject the idea because again, that depend on the nature of those changes. The only way to differentiate from the changes we already have and the future changes is to have them in separate commits, but then the next X commits would blend into the 39 commits we already agreed on so far. However, if we agree on not adding more commits, then in deed there is no reason to manually squash them. Note that when a force-push happens the old HEAD commit hash will be still visible on the PR, albeit less obvious. The notes about inline comments is probably valid. They would be at risk of getting lost. https://github.com/llvm/llvm-project/pull/198211 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
