================
@@ -217,10 +217,9 @@ Expected<std::unique_ptr<Module>>
getBitcodeModule(StringRef File,
return createStringError(Err.getMessage());
}
-/// Gather all SYCL device library files that will be linked with input device
-/// files.
+/// Gather all device library files.
/// The list of files and its location are passed from driver.
-Expected<SmallVector<std::string>> getSYCLDeviceLibs(const ArgList &Args) {
+Expected<SmallVector<std::string>> getDeviceLibs(const ArgList &Args) {
----------------
bader wrote:
There should be no "device" or "host" concept in clang-sycl-linker tool.
According to my understanding, clang-sycl-linker handles just "libraries" w/o
separating them on "HostLibs" and "DeviceLibs".
```suggestion
Expected<SmallVector<std::string>> getLibraryNames(const ArgList &Args) {
```
I assume that --device-libs option has been copied "as-is" from the
clang-linker-wrapper. It should be renamed accordingly (e.g.
https://github.com/intel/llvm/blob/5a7b1ef76b83fdcc42131e2fc80b949f75939e49/clang/tools/clang-nvlink-wrapper/NVLinkOpts.td#L28-L40)
https://github.com/llvm/llvm-project/pull/199777
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
