AaronBallman wrote: > Thanks a lot for the explanation. I will use more accurate wording in the > commit description. > > > Yes, I'm just asking for a different kind of RUN line... where you're > > testing that the builtins emit the expected LLVM IR. > > Thanks, for point - I've created pr #199968 with test coverage for all the > added builtins.
Thank you! I'll review that one shortly. In the future, I'd also recommend adding @svenvh as a reviewer to an OpenCL-related changes, as he's the OpenCL maintainer. https://github.com/llvm/llvm-project/pull/199422 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
