svenvh wrote: Thanks for bringing this one to my attention, Aaron!
> I think the changes are likely fine but I think a revert is warranted so this > goes through proper review. No concerns from my side regarding the OpenCLBuiltins.td additions. For this instance a post-commit review suffices I'd say, no need to go through a revert-reland cycle. As these are vendor specific builtins, I'm happy for your co-workers to review/approve the test additions as long as the testing time remains reasonable. https://github.com/llvm/llvm-project/pull/199422 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
