https://github.com/melver requested changes to this pull request.
The fact you blindly updated `clang/test/Sema/warn-thread-safety-analysis.c` (major regression btw) instead of investigating what went wrong tells me you don't understand what the intended behaviour is meant to be. Sure the tests pass, but this is a red flag to me. What's the intent of this change? Are you generating this code (with or without AI doesn't matter) without understanding of the broader context and subsystems you've touched? Chunks of the code you have now is derived from my branch (I don't mind), but adapted in a way that caused a major regression (false positive in TSA). Hmm... https://github.com/llvm/llvm-project/pull/199241 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
