================
@@ -335,6 +335,16 @@ ExprDependence clang::computeDependence(CXXThisExpr *E) {
   return D;
 }
 
+ExprDependence clang::computeDependence(CThisExpr *E) {
+  // The implicit reference is type-dependent if the enclosing record type
+  // is dependent. This primarily matters when the C struct is utilized 
+  // within a C++ template context. 
+  // Unlike CXXThisExpr, CThisExpr cannot be captured by lambdas or 
+  // explicitly object parameters, so we only need to forward the implied 
+  // type's dependence.
----------------
ojhunt wrote:

I'm not sure that this comment is needed, but it certainly does not need to be 
this large - you should just be describing anything novel, if anything at all 
(compare the code elsewhere).

In general large comments make code harder to understand, not easier.

https://github.com/llvm/llvm-project/pull/199241
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to