llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Rose Hudson (rosefromthedead) <details> <summary>Changes</summary> It seems like there is precedent for using addClangWarningOptions in the driver to set warning default states per-target, in e.g. AMDGPU. --- Full diff: https://github.com/llvm/llvm-project/pull/202300.diff 3 Files Affected: - (modified) clang/lib/Driver/ToolChains/PS4CPU.cpp (+5) - (modified) clang/lib/Driver/ToolChains/PS4CPU.h (+2) - (modified) clang/test/Driver/ps4-ps5-toolchain.c (+5) ``````````diff diff --git a/clang/lib/Driver/ToolChains/PS4CPU.cpp b/clang/lib/Driver/ToolChains/PS4CPU.cpp index e40127bc2baeb..00e6e54a4fda5 100644 --- a/clang/lib/Driver/ToolChains/PS4CPU.cpp +++ b/clang/lib/Driver/ToolChains/PS4CPU.cpp @@ -650,6 +650,11 @@ void toolchains::PS4PS5Base::addClangTargetOptions( } } +void toolchains::PS4PS5Base::addClangWarningOptions(ArgStringList &CC1Args) const { + CC1Args.push_back("-Wnonportable-include-path-separator"); + CC1Args.push_back("-Wnonportable-system-include-path"); +} + // PS4 toolchain. toolchains::PS4CPU::PS4CPU(const Driver &D, const llvm::Triple &Triple, const llvm::opt::ArgList &Args) diff --git a/clang/lib/Driver/ToolChains/PS4CPU.h b/clang/lib/Driver/ToolChains/PS4CPU.h index e555847b7d5c4..baa14ee06c1dc 100644 --- a/clang/lib/Driver/ToolChains/PS4CPU.h +++ b/clang/lib/Driver/ToolChains/PS4CPU.h @@ -114,6 +114,8 @@ class LLVM_LIBRARY_VISIBILITY PS4PS5Base : public Generic_ELF { const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args, Action::OffloadKind DeviceOffloadingKind) const override; + void addClangWarningOptions(llvm::opt::ArgStringList &CC1Args) const override; + llvm::DenormalMode getDefaultDenormalModeForType( const llvm::opt::ArgList &DriverArgs, const JobAction &JA, const llvm::fltSemantics *FPType) const override { diff --git a/clang/test/Driver/ps4-ps5-toolchain.c b/clang/test/Driver/ps4-ps5-toolchain.c index c9987c2b5758b..f87f1fae491e4 100644 --- a/clang/test/Driver/ps4-ps5-toolchain.c +++ b/clang/test/Driver/ps4-ps5-toolchain.c @@ -16,3 +16,8 @@ // RUN: %clang %s -target x86_64-sie-ps5 -### 2>&1 | FileCheck -check-prefix=JUMPTABLESIZES %s // JUMPTABLESIZES: "-mllvm" "-emit-jump-table-sizes-section" // JUMPTABLESIZES: "-plugin-opt=-emit-jump-table-sizes-section" + +// Verify non-portable include path diagnostics are enabled. +// RUN: %clang %s -target x86_64-sie-ps5 -### 2>&1 | FileCheck --check-prefix=NONPORTABLE-INCLUDE %s +// NONPORTABLE-INCLUDE: "-Wnonportable-include-path-separator" +// NONPORTABLE-INCLUDE: "-Wnonportable-system-include-path" `````````` </details> https://github.com/llvm/llvm-project/pull/202300 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
