TomWeaver18 wrote: @owenca Hey, thanks so much for proposing the fix. I've run into the issue that this trys to fix locally and tried applying your patch, it didn't seem to resolve the issue with the following error for multiple files:
``` [2.190s: 86/191] Checking format of <repo_path>/llvm-project/clang/unittests/Format/SortImportsTestJava.cpp FAILED: [code=1] tools/clang/lib/Format/check_format_depend_85 cmd.exe /C "cd /D <build_path>\tools\clang\lib\Format && <build_path>\bin\clang-format.exe <repo_path>/llvm-project/clang/unittests/Format/SortImportsTestJava.cpp | fc <repo_path>/llvm-project/clang/unittests/Format/SortImportsTestJava.cpp - && touch check_format_depend_85" FC: cannot open <repo_path>/LLVM-PROJECT/CLANG/UNITTESTS/FORMAT/SORTIMPORTSTESTJAVA.CPP - No such file or folder ``` This is rather unfortunate as I'm very keen to see the build bot (and therefore our internal CI too) green from a fix. I'm going to have to revert the original patch as it has been over 2 days now with no coverage for our bot. Feel free to tag me if you need any further assistance getting a fix in for this. all the best, Tom W https://github.com/llvm/llvm-project/pull/205036 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
