steakhal wrote: Welcome here. Please format your code. This is a functional change, so you must also include a test demonstrating the affected behavior. That said, You should probably also have a look at code coverage to not miss any of the unlikely branches that you would forgot to cover with tests otherwise. Mind that even though there are no build bots testing Z3 configs downstream - especially not the Z3 constraint solver parts (because that is broken/crashing on multiple fronts) we would still likely want to include some tests to honour the process.
https://github.com/llvm/llvm-project/pull/205078 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
