NagyDonat wrote:

> Mind that even though there are no build bots testing Z3 configs downstream - 
> especially not the Z3 constraint solver parts (because that is 
> broken/crashing on multiple fronts) we would still likely want to include 
> some tests to honour the process.

Yes, and after adding the tests you _must_ run the analyzer tests (i.e. build 
the build target `check-clang-analysis`) locally and verify that they pass. It 
is always a good practice to run the tests before pushing; but usually the 
github buildbots ("Build and Test Linux" etc.) act as a "safety net" that catch 
buggy commits -- however these buildbots currently cannot build with Z3 and 
skip the tests that require Z3.

https://github.com/llvm/llvm-project/pull/205078
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to