HighCommander4 wrote: Checking the behaviour of the code snippets from [this comment](https://github.com/llvm/llvm-project/pull/206716#issuecomment-4878686927) with the new patch, what I'm seeing is:
* The first two are now consistent (we get `int night` in both cases). * But the inconsistency between code completion and signature help is still there. Note that this inconsistency is not present upstream, so we'd be introducing a regression if we land the patch in its current form. Moreover, in the automated test cases (which are passing), the selected declaration is `void moon(int, int day);`, which is the _last_ one with parameter names (whereas in the tests above `(int night)` is the first one)... so I feel like there's something I'm missing still. https://github.com/llvm/llvm-project/pull/206716 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
