timon-ul wrote: So here are all the callers of `FromatFunctionParameter`, so all the possible ones we should adapt. <img width="607" height="292" alt="grafik" src="https://github.com/user-attachments/assets/c3079d94-d73c-49fd-83ec-d47948352bba"; />
I really would love to directly adapt it in the method itself, but since we only pass it the parameter we cannot go back to get the alternative function declarations. That being said not all of them seem that important to adapt. - `AddFunctionParameterChunks` already adapted - `AddObjCBlockCall` does not get its parameter from a `FunctionDecl`, comes from a `FunctionTypeLoc`, has no redecls directly, probably fine to ignore - `AddOverloadAggregateChunks` comes from `RecordDecl`, not sure if this even makes sense for record declarations? - `AddOverloadParameterChunks` will add for this. - `createCodeCompletionStringForDecl` this one calls the first function for C and C++ but for ObjC it calls `FormatFunctionParameter`directly, not sure how much imporatce we have for ObjC but technically I could add it. - `formatBlockPlaceholder` exactly same issue as `AddObjCBlockCall` so I assume fine to ingore too? So in conclusion: I think only the 5th caller would make sense to adapt on top, but not sure if we think this is neccessary. https://github.com/llvm/llvm-project/pull/206716 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
