Lu4nScr1pt1ng wrote: > Looks well motivated, well scoped and tested. Thanks for the patch. I'd say, > not something common for new contributions. Thank you for coming. I had some > inline questions but this is IMO already good to go! > > EDIT: GH is so buggy. It's amazing.
Thanks for the kind words, i'm happy with my first PR in llvm-project GH is being buggy for me too, i tried to apply your suggestion 5 times and every time it gave an error, then suddenly it applied the suggestion 5 times lol https://github.com/llvm/llvm-project/pull/207793 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
