https://github.com/AaronBallman approved this pull request.
LGTM! That said, the precommit CI failure does worry me a little bit. It seems like it should not be related to changes here but it's a failure with DiagnosticIDs.cpp which is being changed in this PR: ``` FAILED: [code=2] tools/clang/lib/Basic/CMakeFiles/obj.clangBasic.dir/DiagnosticIDs.cpp.obj sccache C:\clang\clang-msvc\bin\clang-cl.exe /nologo -TP -DCLANG_BUILD_STATIC -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\tools\clang\lib\Basic -IC:\_work\llvm-project\llvm-project\clang\lib\Basic -IC:\_work\llvm-project\llvm-project\clang\include -IC:\_work\llvm-project\llvm-project\build\tools\clang\include -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include /DWIN32 /D_WINDOWS /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4 -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /O2 /Ob2 -std:c++17 -MD -UNDEBUG /EHs-c- /GR- /showIncludes /Fotools\clang\lib\Basic\CMakeFiles\obj.clangBasic.dir\DiagnosticIDs.cpp.obj /Fdtools\clang\lib\Basic\CMakeFiles\obj.clangBasic.dir\ -c -- C:\_work\llvm-project\llvm-project\clang\lib\Basic\DiagnosticIDs.cpp sccache: error: failed to execute compile sccache: caused by: error reading compile response from server sccache: caused by: Failed to read response header sccache: caused by: An existing connection was forcibly closed by the remote host. (os error 10054) ``` I don't see *why* this would relate to your changes, though, so I think we're fine to land. But there may be post-commit fallout if the failure is related to this PR. https://github.com/llvm/llvm-project/pull/202624 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
