Rakete1111 added inline comments.
================ Comment at: lib/Sema/Sema.cpp:445 + // If it is a macro from system header, and if the macro name is not "NULL", + // do not warn. + SourceLocation MaybeMacroLoc = E->getLocStart(); ---------------- That comment doesn't really add anything IMO. It just says what the code just below says. ================ Comment at: lib/Sema/Sema.cpp:447 + SourceLocation MaybeMacroLoc = E->getLocStart(); + if (SourceMgr.isInSystemMacro(E->getLocStart()) && + !findMacroSpelling(MaybeMacroLoc, "NULL")) ---------------- Please use `MaybeMacroLoc` there too. Repository: rL LLVM https://reviews.llvm.org/D38954 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
