lebedev.ri added inline comments.
================ Comment at: lib/Sema/Sema.cpp:445 + // If it is a macro from system header, and if the macro name is not "NULL", + // do not warn. + SourceLocation MaybeMacroLoc = E->getLocStart(); ---------------- Rakete1111 wrote: > That comment doesn't really add anything IMO. It just says what the code just > below says. I don't disagree. It seems to be the common pattern for the code in this file. Having both the code and the comment might help convey the idea better. Repository: rL LLVM https://reviews.llvm.org/D38954 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
