arphaman added inline comments.

================
Comment at: lib/CodeGen/CodeGenPGO.cpp:186
+    if (Hash.getHashVersion() != PGO_HASH_V1)
+      Type = getHashType(Hash.getHashVersion(), S);
+
----------------
Am I missing something or will this call always return the same type as before 
since the first `if` will weed out statements which have hash only in v2 (since 
`getHashType(PGO_HASH_V1, S)` will return `None` for the new statements)?


https://reviews.llvm.org/D39446



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to