guillem-bartrina-sonarsource wrote:

> Given the numbers, my argument was that you should probably test your 
> ASTImporter changes using unittests.

Note that the updates I made to the existing unit tests, as well as the new 
unit test, already reflect the new behavior. In other words, I believe I am 
already testing the changes using unit tests. Do you think I should add more?

https://github.com/llvm/llvm-project/pull/214009
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to