guillem-bartrina-sonarsource wrote:

> It looks like that failed nodes are not removed from the lookup table (name 
> lookup in `DeclContext`) which can probably cause problems later. This can be 
> something to fix later.

Indeed, they are not removed.

> I see that an LLDB test started failing: 
> https://github.com/llvm/llvm-project/actions/runs/31012683468/job/92328750113?pr=214009#step:3:14210.
> 
> If amending this test is not an option, we can approach the fix differently. 
> Similar to how we detect function decl cycles, we can do the same for var 
> decls.

The tests are failing only because of this. I'll amend them if you give me the 
green light.

https://github.com/llvm/llvm-project/pull/214009
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to