Xazax-hun wrote: I hope to take another look soon. In the meantime I wanted to forward some notes from Claude that might be relevant:
- Both FunctionTableKey(…, const llvm::SmallVectorImpl<IdentifierID> &ParameterTypeIDs) constructors now have zero callers — every construction site goes through the FunctionTableSelectorKey form (APINotesFormat.h:403, APINotesReader.cpp:115) or the 2-arg form in getNameOnlyKey(). Delete them. - The free formatAPINotesFunctionSelector(optional<ArrayRef>, optional<Object>) now has exactly one caller: FunctionSelector::format() itself. Fold it in — that finishes @j-hui's suggestion. - FunctionObjectSelector::format() declares std::string Ref = "Ref: "; inside if (Ref), shadowing the member and forcing *this->Ref. Rename the local. - if (flags & RefLValue) assert(!(flags & RefRValue) && …); should just be assert(!((flags & RefLValue) && (flags & RefRValue)) && …); https://github.com/llvm/llvm-project/pull/216148 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
