Hendrik =?utf-8?q?Hübner?= <[email protected]>,
Hendrik =?utf-8?q?Hübner?= <[email protected]>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/[email protected]>
================
@@ -1412,15 +1412,14 @@ namespace {
CGF.Builder.CreateCondBr(ShouldRethrow, RethrowBB, ContBB);
CGF.EmitBlock(RethrowBB);
- if (SavedExnVar) {
+ if (!SavedExnVar) {
+ CGF.EmitNoreturnRuntimeCallOrInvoke(RethrowFn, {});
+ } else {
CGF.EmitRuntimeCallOrInvoke(RethrowFn, CGF.Builder.CreateAlignedLoad(
CGF.Int8PtrTy,
SavedExnVar,
CGF.getPointerAlign()));
-
- } else {
- CGF.EmitRuntimeCallOrInvoke(RethrowFn);
+ CGF.Builder.CreateUnreachable();
----------------
aheejin wrote:
Not related to Wasm case, but can't we use `EmitNoreturnRuntimeCallOrInvoke`
here too? Also nit, but I think the original order `if (SavedExnVar) ... else
...` is more intuitive.
https://github.com/llvm/llvm-project/pull/218967
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
