Hendrik =?utf-8?q?Hübner?= <[email protected]>,
Hendrik =?utf-8?q?Hübner?= <[email protected]>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/[email protected]>
================
@@ -224,6 +220,7 @@ void CGObjCRuntime::EmitTryCatchStmt(CodeGenFunction &CGF,
}
// We save the old funclet pad here before we traverse each catch handler.
+ llvm::Instruction *SavedFuncletPad = CGF.CurrentFuncletPad;
SaveAndRestore RestoreCurrentFuncletPad(CGF.CurrentFuncletPad);
----------------
aheejin wrote:
```suggestion
{
SaveAndRestore RestoreCurrentFuncletPad(CGF.CurrentFuncletPad);
```
Do we need to use both `SavedFuncletPad` and `RestoreCurrentFuncletPad`? If we
put line 224-309 within a block, `RestoreCurrentFuncletPad` will restore it
automatically. (There should be a matching `}` after line 309)
https://github.com/llvm/llvm-project/pull/218967
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
