Sirraide wrote: > would you prefer a single commit or separate commits?
As in on this pr? We generally don’t really care about the commit history of a pr since we do squash+merge when the pr is merged anyway. The main thing I’d like is if you could use merge commits rather than rebasing and avoid force-pushing as that makes it harder for me to figure out what changed since my last review. That said, I don’t think it matters for this patch. That’s more of a general thing for larger patches where I need to come back a week later and then try and figure out what changed https://github.com/llvm/llvm-project/pull/228990 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
