================
@@ -1620,8 +1620,7 @@ 
PassBuilder::buildModuleOptimizationPipeline(OptimizationLevel Level,
     MPM.addPass(AssignGUIDPass());
     MPM.addPass(WholeProgramDevirtPass(
         /*ExportSummary*/ nullptr,
-        /*ImportSummary*/ nullptr,
-        /*DevirtSpeculatively*/ PTO.DevirtualizeSpeculatively));
----------------
hassnaaHamdi wrote:

`-devirtualize-speculatively` is just for testing purposes, It's used when we 
test running WPD separately.
`-enable-devirtualize-speculatively` will be needed if we run the default 
pipeline, like the case of this test: 
llvm/test/Transforms/PhaseOrdering/speculative-devirt-then-inliner.ll but I 
think it's not critical to keep it, it could be dropped. But passing 
`PTO.DevirtualizeSpeculatively` is fundamental here to tell the WPD that the 
feature is enabled. I think we also need to pass it in LTO ?

https://github.com/llvm/llvm-project/pull/233380
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to