https://github.com/Men-cotton requested changes to this pull request.
As you note in the PR description, Sema represents static method calls as ordinary `CallExpr` nodes. The proposed tests therefore pass without the patch. IMO, removing these branches from both classic Clang and CIR may be more appropriate. Based on an AI-assisted investigation, the branch in classic Clang seems to be a historical leftover. It was introduced in 8f4fd60c47a5, when Sema could produce `CXXMemberCallExpr` nodes for static method calls. Subsequent changes in 2d74de96325e and 0009fcc39e19 moved those calls to the ordinary `CallExpr` path, so the branch appears unreachable through normal Sema-generated ASTs. Regardless of whether we keep or remove these branches, I think the PR need to be revised since their tests do not check the behavior being changed. https://github.com/llvm/llvm-project/pull/237420 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
