malaperle added a comment.
In https://reviews.llvm.org/D40548#947081, @ioeric wrote:
> Hi Marc, the patch is not ready for review yet. I am still cleaning up the
> prototype and will let you know when it's ready for review.
I guess it was ready to review since it was submitted? ;)
================
Comment at: clangd/index/Index.h:134
+ virtual bool
+ fuzzyFind(Context &Ctx, const FuzzyFindRequest &Req,
+ std::function<void(const Symbol &)> Callback) const = 0;
----------------
I think a more generic std::function would be useful, similar to the
indexstore's filter
```
bool searchSymbols(llvm::function_ref<bool(IndexRecordSymbol, bool &stop)>
filter,
llvm::function_ref<void(IndexRecordSymbol)> receiver)
```
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40548
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
