khuttun marked 2 inline comments as done.
khuttun added inline comments.
================
Comment at: test/clang-tidy/bugprone-unused-return-value.cpp:163
+
+void noWarning() {
+ auto AsyncRetval1 = std::async(increment, 42);
----------------
aaron.ballman wrote:
> Sorry, I just realized that we're missing a test case for a common situation
> -- where the result is used as part of another call expression. Can you add a
> test to `noWarning()` to make sure this does not warn:
> ```
> std::vector<int> v;
> extern void f(bool);
>
> f(v.empty()); // Should not warn
> ```
See line 199 in this file.
https://reviews.llvm.org/D41655
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
