aaron.ballman added inline comments.
================
Comment at: test/clang-tidy/bugprone-unused-return-value.cpp:210
+ // test that the check is disabled inside GNU statement expressions
+ ({ std::async(increment, 42); });
+ auto StmtExprRetval = ({ std::async(increment, 42); });
----------------
Not diagnosing this case is questionable -- the return value *is* unused and
that's a bad thing. However, this is likely to be an uncommon code pattern, so
I'd be fine if you added a FIXME to the AST matcher code that excludes GNU
expression statements to handle this case someday, and add a FIXME comment here
as well so we know what we would like the behavior to be (you could fix the
FIXMEs in a follow-up patch if you'd like).
https://reviews.llvm.org/D41655
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
