Hahnfeld resigned from this revision.
Hahnfeld added a comment.

In https://reviews.llvm.org/D42755#995593, @vsapsai wrote:

> Good suggestion for explaining the problem with `file_time_type::min()` in 
> more detail. Also PR35990 <https://bugs.llvm.org/show_bug.cgi?id=35990> has 
> some details on how different filesystems handle `file_time_type::min()`. As 
> the change doesn't fix the PR, I don't think it is worth mentioning it in the 
> commit message but it can be still useful in code review discussion.

If there is an upstream bug report, please link to that one. With that 
information the changes look good, but I'd like @EricWF to accept.


cfe-commits mailing list

Reply via email to