echristo added inline comments.

Comment at: lib/CodeGen/CodeGenModule.cpp:1318-1325
+        llvm::AttrBuilder Attrs;
+        if (GetCPUAndFeaturesAttributes(D, Attrs)) {
+          // We know that GetCPUAndFeaturesAttributes will always have the
+          // newest set, since it has the newest possible FunctionDecl, so the
+          // new ones should replace the old.
+          F->removeFnAttr("target-cpu");
+          F->removeFnAttr("target-features");
This feels awkward here. On a quick glance I'm not sure why we need this if 
we're adding above... is it possible to delay in such a way that we're not 
trying to add twice?

  rC Clang

cfe-commits mailing list

Reply via email to