stephanemoore marked an inline comment as done. stephanemoore added a comment.
In https://reviews.llvm.org/D43581#1018499, @aaron.ballman wrote: > This LGTM! Do you need someone to commit on your behalf? I would be happy to commit assuming that I am able to and can meet submission requirements. I see a "Submit" button in Phabricator that I assume will land the commit if I press it? I found some submission guidelines in the LLVM Developer Policy <http://llvm.org/docs/DeveloperPolicy.html>. Are there any other submission guidelines I should follow? I ran the LLVM and Clang regression tests (by running `make check-all` from my LLVM build directory) and I encountered a failure in "Bindings/Go/go.test": ******************** TEST 'LLVM :: Bindings/Go/go.test' FAILED ******************** Script: -- /Users/mog/projects/llvm-build/bin/llvm-go go=/usr/local/go/bin/go test llvm.org/llvm/bindings/go/llvm -- Exit Code: 1 Command Output (stdout): -- FAIL llvm.org/llvm/bindings/go/llvm [build failed] -- Command Output (stderr): -- # llvm.org/llvm/bindings/go/llvm In file included from /var/folders/qh/4y215hgd4zqg30v9q04czw58005k3k/T/lit_tmp_7sZYWR/gopath735545420/src/llvm.org/llvm/bindings/go/llvm/analysis.go:17: In file included from /Users/mog/projects/llvm/include/llvm-c/Analysis.h:22: In file included from /Users/mog/projects/llvm/include/llvm-c/Types.h:17: /Users/mog/projects/llvm-build/include/llvm/Support/DataTypes.h:35:10: fatal error: 'math.h' file not found #include <math.h> ^~~~~~~~ 1 error generated. -- ******************** I reran these tests on a clean checkout and I still encountered the failure so I presume that this failure is unrelated? I have also been trying to run the `test-suite` but I have been encountering Python exceptions while trying to run `lnt` 😕. If someone wants to submit on my behalf that works for me. If not, I can also continue trying to drive this myself (though verification of submission requirements would be helpful in that case). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43581 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
