rjmccall added inline comments.
================ Comment at: include/clang/Driver/Options.td:1735 + HelpText<"Whether to use IR type names (option: none, use)">, + Values<"none,use">; def relocatable_pch : Flag<["-", "--"], "relocatable-pch">, Flags<[CC1Option]>, ---------------- This is an unusual spelling for the option in a number of ways: - We generally don't use `--` options; I think all the ones we have are strictly for legacy support. - A lot of similar options are in the `-f` or `-m` namespaces, although that's not as consistent and we could reasonably make this an exception. - `-foo=bar` options are generally used for options that are expected to take a variety of different values; this seems basically boolean. Are you expecting future growth here? Repository: rC Clang https://reviews.llvm.org/D43805 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
