EricWF marked an inline comment as done.
EricWF added inline comments.

Comment at: lib/CodeGen/CGBuiltin.cpp:1947-1948
+    const auto *Record = ArgTy->getAsCXXRecordDecl();
+    if (CGM.getCodeGenOpts().StrictVTablePointers && Record &&
+        Record->isDynamicClass())
+      Ptr = Builder.CreateInvariantGroupBarrier(Ptr);
rsmith wrote:
> I think you also need to catch class types that contain dynamic classes as 
> subobjects.
Only by-value subobjects, or also reference subobjects?

cfe-commits mailing list

Reply via email to