asb added inline comments.

Comment at: test/Driver/riscv-arch.c:151
+// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-LETTER %s
+// RV32-LETTER: error: invalid arch name 'rv32e',
+// RV32-LETTER: first letter should be 'e', 'i' or 'g'
But rv32e is a valid arch name.

Comment at: test/Driver/riscv-arch.c:161
+// RUn: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-STD-INVAL %s
+// RV32-STD-INVAL: error: invalid arch name 'rv32imC',
+// RV32-STD-INVAL: unsupported standard user-level extension 'C'
Both GCC and the current clang ISA string logic expect lowercase letters. 
However, the spec does state that the string should be treated as case 
insensitive. We're probably best following GCC, though perhaps we should 
discuss this with them

cfe-commits mailing list

Reply via email to