asb added a comment. I've added a few comments on tweaking the error messages based on your tests.
================ Comment at: test/Driver/riscv-arch.c:157 +// RV32-STR: error: invalid arch name 'rv32', +// RV32-STR: string must begin with rv32 or rv64 + ---------------- But the given string does begin with rv32. 'string must begin with rv32{i,e,g} or rv64{i,g}'? ================ Comment at: test/Driver/riscv-arch.c:167 +// RV32-ORDER: error: invalid arch name 'rv32imcq', +// RV32-ORDER: unsupported canonical order of extension 'q' + ---------------- I don't think this message is clear, specifically 'unsupported canonical order...'. How about 'error: standard extension not given in canonical order' ================ Comment at: test/Driver/riscv-arch.c:203 +// RV32SX-NAME: unsupported non-standard supervisor-level extension +// RV32SX-NAME: name missing 'sx' + ---------------- I think this would be clearer if you said "name missing after 'sx'" ================ Comment at: test/Driver/riscv-arch.c:208 +// RV32S-NAME: error: invalid arch name 'rv32is', +// RV32S-NAME:unsupported standard supervisor-level extension name missing 's' + ---------------- Ditto. ================ Comment at: test/Driver/riscv-arch.c:213 +// RV32ALL-NAME: error: invalid arch name 'rv32ix_s_sx', +// RV32ALL-NAME: unsupported non-standard user-level extension name missing 'x' + ---------------- Ditto. https://reviews.llvm.org/D45284 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits