djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.

Looks good.

Comment at: lib/Format/TokenAnnotator.cpp:2357
+      return false;
+    else
+      // Protocol list -> space if configured. @interface Foo : Bar <Baz>
Don't use else after return.

I'd have a slight preference for writing:

  bool IsLightweightGeneric = 
      Right.MatchingParen && Right.MatchingParen->Next &&
  return !IsLightweightGeneric && Style.ObjCSpaceBeforeProtocolList;

Then I think it might not even need a comment (or a shorter one).

  rC Clang

cfe-commits mailing list

Reply via email to